V2.0.1 unit of measure update docstring to allow use for variable characteristics #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrangeTux
suggested changes
Nov 7, 2023
ocpp/v16/enums.py
Outdated
| @@ -773,6 +774,7 @@ class UnitOfMeasure(str, Enum): | |||
| k = "K" | |||
| percent = "Percent" | |||
| hertz = "Hertz" | |||
| b = "Bytes" | |||
There was a problem hiding this comment.
This change is done to the v16 enum. It should be applied to the v201 enum, right?
There was a problem hiding this comment.
Yes, so it is only an addition now to the doc string
Jared-Newell-Mobility
changed the title
OrangeTux
previously approved these changes
Nov 7, 2023
…nd-update-docstring-to-allow-use-for-variableCharacteristics
Jared-Newell-Mobility
deleted the
v2.0.1-UnitOfMeasureType---Enums-missing-and-update-docstring-to-allow-use-for-variableCharacteristics
branch
ajmirsky
pushed a commit
to ajmirsky/ocpp
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510