Add NotImplemented exception

[drc38]

See #426 for background discussion

[drc38]

Any suggestions on how to fix the circular import? Or will the _handle_call method need to be overridden in each version?

[Jared-Newell-Mobility]

Linked issue / enhancement - #493

[OrangeTux]

You could move the imports of the Action enums to appear after the ChargePoint class. Not sure if that's the nicest solution, though.

[OrangeTux]

Thanks for the PR!

Can you cover the changes by unit tests?

[drc38]

@OrangeTux, not sure why the mock is not being called to test an invalid action. Appreciate your assistance.

Got it sorted, ready for your final review.

[drc38]

I notice messages.py can raise a NotImplementedError when validating the message content, imo this is incorrect and should be a ValidationError?

[drc38]

@OrangeTux @Jared-Newell-Mobility, Suggest amending to the following:

except OSError:
        raise ValidationError(
            details={"cause": f"JSON validation schema not found for action: {message.action}"}
        )
except json.JSONDecodeError:
       raise ValidationError(
            details={"cause": f"Error in decoding JSON validation schema for action: {message.action}"}
       )

Let me know if you're happy with the existing changes proposed and whether to include this in the same PR or separately, if agreed to.

[OrangeTux]

Almost there!

[OrangeTux]

@drc38 Are you referring to this?

ocpp/ocpp/messages.py

Lines 220 to 223 in e452f5c

	except (OSError, json.JSONDecodeError):
	raise NotImplementedError(
	details={"cause": f"Failed to validate action: {message.action}"}
	)

When a schema doesn't exists, an OSError is raised. This mechanism is (mis)used to identify calls for non existing Actions. I think a NotSupportedError should be raised in that case.

If a file is found, but it can't be parsed as JSON a json.JSONDecoder error is raised. I agree with you that this error should be mapped to a ValidationError.

Let's fix that in a seperate PR.

[drc38]

@drc38 Are you referring to this?

ocpp/ocpp/messages.py

Lines 220 to 223 in e452f5c

	except (OSError, json.JSONDecodeError):
	raise NotImplementedError(
	details={"cause": f"Failed to validate action: {message.action}"}
	)

When a schema doesn't exists, an OSError is raised. This mechanism is (mis)used to identify calls for non existing Actions. I think a NotSupportedError should be raised in that case.

If a file is found, but it can't be parsed as JSON a json.JSONDecoder error is raised. I agree with you that this error should be mapped to a ValidationError.

Let's fix that in a seperate PR.

Ok. Note with this PR the OSError should only be raised on edge cases eg if the json schema file is corrupt. NotImplementedError and NotSupportedError errors will be raised prior to the json validation occurring, taking care of when the schema doesn't exist. Or have I missed something?

[OrangeTux]

Thanks!