Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed that no nmr_only = Trues were created #95

Closed
wants to merge 1 commit into from

Conversation

tiaguinho-code
Copy link
Collaborator

There was some logic mismatch with the internal booleans and the strings passed to the function. Basically, all the full strings were evaluated to true, even if the string was "false"

There was some logic mismatch with the internal booleans and the strings
passed to the function. Basically, all the full strings were evaluated
to true, even if the string was "false"
Copy link
Owner

@mlederbauer mlederbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding! Why exactly do these code changed fix the problem? Shouldn’t we get the same result when we set the variable to a Bool? Isnt it rather a prolem with the code logic in reproduce_results.py?

@mlederbauer
Copy link
Owner

Still not sure if I understand this @tiaguinho-code - thanks a lot for explaining in advance

Copy link
Owner

@mlederbauer mlederbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not resolve the bug as it seems. We need to find the error int he code logic, most likely in scripts/reproduce_results.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants