Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add R-GAT calibration + remove old reference implementation #1943

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Add R-GAT calibration + remove old reference implementation #1943

merged 12 commits into from
Dec 4, 2024

Conversation

pgmpablo157321
Copy link
Contributor

No description provided.

@pgmpablo157321 pgmpablo157321 requested a review from a team as a code owner November 19, 2024 16:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anandhu-eng
Copy link
Contributor

Hi @pgmpablo157321 @arjunsuresh , would this line cause an issue if the default path to mlperf.conf isn’t passed as an argument, since it defaults to searching in the inference/graph/R-GAT folder as mentioned here? Also, is the mlperf.conf file explicitly needed, given that its is now integrated with loadgen?

@arjunsuresh
Copy link
Contributor

yes @pgmpablo157321 now we should not pass mlperf.conf to the reference implementation and subsequently to loadgen as it is already part of the loadgen.

arjunsuresh
arjunsuresh reviewed Nov 26, 2024
View reviewed changes
loadgen/mlperf.conf Outdated Show resolved Hide resolved
@mrmhodak mrmhodak merged commit a2baf12 into master Dec 4, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anandhu-eng anandhu-eng anandhu-eng left review comments

@arjunsuresh arjunsuresh arjunsuresh left review comments

@mrmhodak mrmhodak mrmhodak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgmpablo157321 @anandhu-eng @arjunsuresh @mrmhodak