Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

task(README): Updated README files #5022

Merged
merged 3 commits into from
May 10, 2024

Conversation

VWSCoronaDashboard30
Copy link
Contributor

Summary

  • Aligned some README files with the current status of the dashboard

Copy link
Contributor

@ben-van-eekelen ben-van-eekelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add notification blocks detailing why parts of the documentation have been struck through. Something along the lines of: As of 02-04-2024 The Coronadashboard has been brought offline, so this section is no longer relevant because... (e.g. we can no longer use Sanity; we no longer do releases; etc.)

Copy link
Contributor

@ben-van-eekelen ben-van-eekelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine. I have several small comments.

docs/lokalize-texts.md Outdated Show resolved Hide resolved
docs/developers.md Outdated Show resolved Hide resolved
packages/app/README.md Show resolved Hide resolved
packages/app/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ben-van-eekelen ben-van-eekelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/app/README.md Outdated Show resolved Hide resolved
@VWSCoronaDashboard30 VWSCoronaDashboard30 merged commit d3819f6 into develop May 10, 2024
7 checks passed
@VWSCoronaDashboard30 VWSCoronaDashboard30 deleted the task/update-readme-files branch May 10, 2024 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants