Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3694: enforce rate limit rule #2942

Merged
merged 2 commits into from
Nov 18, 2024
Merged

UML-3694: enforce rate limit rule #2942

merged 2 commits into from
Nov 18, 2024

Conversation

jay-whitwell
Copy link
Contributor

@jay-whitwell jay-whitwell commented Nov 18, 2024

Purpose

Moves the custom rate limit from count to block. This shouldn't have any effect on real users.

Fixes UML-3694

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@jay-whitwell jay-whitwell requested a review from a team as a code owner November 18, 2024 12:58
@github-actions github-actions bot added the terraform Pull requests that update Terraform code label Nov 18, 2024
@jay-whitwell jay-whitwell merged commit 9b00d82 into main Nov 18, 2024
25 checks passed
@jay-whitwell jay-whitwell deleted the UML-3694 branch November 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants