-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UML-3056 initial code and working test #2360
Merged
MishNajam
merged 31 commits into
main
from
UML-3056-implement-service-api-endpoint-to-handle-redirect-uri-generation
Oct 11, 2023
Merged
UML-3056 initial code and working test #2360
MishNajam
merged 31 commits into
main
from
UML-3056-implement-service-api-endpoint-to-handle-redirect-uri-generation
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmachell
reviewed
Oct 4, 2023
…andle-redirect-uri-generation
Codecov Report
@@ Coverage Diff @@
## main #2360 +/- ##
============================================
+ Coverage 91.96% 92.00% +0.03%
- Complexity 1455 1457 +2
============================================
Files 274 275 +1
Lines 6597 6629 +32
============================================
+ Hits 6067 6099 +32
Misses 513 513
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MishNajam
force-pushed
the
UML-3056-implement-service-api-endpoint-to-handle-redirect-uri-generation
branch
from
October 5, 2023 16:35
6effc6c
to
8027ab4
Compare
MishNajam
force-pushed
the
UML-3056-implement-service-api-endpoint-to-handle-redirect-uri-generation
branch
from
October 10, 2023 13:12
db1f89d
to
65dab71
Compare
ramchale
previously approved these changes
Oct 10, 2023
…andle-redirect-uri-generation
…andle-redirect-uri-generation
…andle-redirect-uri-generation
…andle-redirect-uri-generation
MishNajam
commented
Oct 11, 2023
service-api/app/src/App/src/Handler/OneLoginAuthorisationRequestHandler.php
Outdated
Show resolved
Hide resolved
…andle-redirect-uri-generation
nickdavis2001
approved these changes
Oct 11, 2023
MishNajam
deleted the
UML-3056-implement-service-api-endpoint-to-handle-redirect-uri-generation
branch
October 11, 2023 13:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Service and Handler classes created in the service api layer that returns an authorisation uri string in the following format:
Source
Fixes UML-3056
Checklist