Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3056 initial code and working test #2360

Conversation

MishNajam
Copy link
Contributor

@MishNajam MishNajam commented Oct 4, 2023

Purpose

Service and Handler classes created in the service api layer that returns an authorisation uri string in the following format:

Screenshot 2023-10-10 at 17 05 48

Source

Fixes UML-3056

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@MishNajam MishNajam requested a review from a team as a code owner October 4, 2023 09:55
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2360 (709c994) into main (d7694e9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 709c994 differs from pull request most recent head f93f7ba. Consider uploading reports for the commit f93f7ba to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2360      +/-   ##
============================================
+ Coverage     91.96%   92.00%   +0.03%     
- Complexity     1455     1457       +2     
============================================
  Files           274      275       +1     
  Lines          6597     6629      +32     
============================================
+ Hits           6067     6099      +32     
  Misses          513      513              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.81% <100.00%> (+0.04%) ⬆️
use-an-lpa-front 89.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...entication/OneLoginAuthorisationRequestService.php 100.00% <100.00%> (ø)

@MishNajam MishNajam force-pushed the UML-3056-implement-service-api-endpoint-to-handle-redirect-uri-generation branch from 6effc6c to 8027ab4 Compare October 5, 2023 16:35
@MishNajam MishNajam force-pushed the UML-3056-implement-service-api-endpoint-to-handle-redirect-uri-generation branch from db1f89d to 65dab71 Compare October 10, 2023 13:12
ramchale
ramchale previously approved these changes Oct 10, 2023
@MishNajam MishNajam merged commit b87582a into main Oct 11, 2023
23 checks passed
@MishNajam MishNajam deleted the UML-3056-implement-service-api-endpoint-to-handle-redirect-uri-generation branch October 11, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants