Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5659: Bump ruby 3.4.1 #7558

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

AP-5659: Bump ruby 3.4.1 #7558

wants to merge 4 commits into from

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Dec 30, 2024 •
edited
Loading

What

Bump ruby 3.3.6 to 3.4.1

Link to story

Also, add label docker image author details

TODO

  • Check why grover was downgraded - last version that did not restrict ruby version was 0.12.3, hence the downgrade to that version
  • test grover 0.12.3 and decide on whether to go with it, wait or fork - on hold til grover gem bumped

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@jsugarman jsugarman requested a review from a team as a code owner December 30, 2024 12:29
@jsugarman jsugarman changed the title AP-5659: Bumper ruby 3.4.1 AP-5659: Bump ruby 3.4.1 Dec 30, 2024
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from 9c10313 to e656290 Compare December 30, 2024 12:40
jsugarman
jsugarman commented Dec 30, 2024
View reviewed changes
Gemfile.lock
@@ -312,8 +315,9 @@ GEM
govuk_notify_rails (3.0.0)
notifications-ruby-client (~> 6.2)
rails (>= 4.1.0)
grover (1.2.1)
nokogiri (~> 1)
grover (0.12.3)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, need to check why this happened

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last version that did not restrict ruby version was 0.12.3, hence the downgrade to that version

@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from e656290 to a53cbfc Compare December 30, 2024 12:54
@jsugarman jsugarman marked this pull request as draft January 6, 2025 12:12
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from a53cbfc to e19630a Compare January 7, 2025 13:03
@jsugarman
AP-5659: Use cucumber main branch temporarily
fd48b9e 
Until cucumber 10 is released there is an error:

```shell
<internal:hash>:37:in 'initialize': unknown keywords: :strict, :proc (ArgumentError)
```

This [issue](cucumber/cucumber-ruby#1769) covers the issue and mentions
main is fixed. So can use that to unblock us?!
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from c0a4d51 to fd48b9e Compare January 7, 2025 13:57
@jsugarman jsugarman removed the blocked label Jan 7, 2025
@jsugarman
AP-5659: Freeze string literals and use unary + for mutable strings
b9d5797 
Handle deprecation notices warning of ruby 4.0 intention to default
string literals to be frozen/immutable.

```shell
/Users/joel.sugarman/github/ministryofjustice/laa-apply-for-legal-aid/app/helpers/hash_format_helper.rb:23:
  warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)
```
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from 47e135e to b9d5797 Compare January 7, 2025 16:50
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jsugarman
Copy link
Contributor Author

Agreed in devtime to pause Civil Apply ruby 3.4.1 bump until grover gem is resolved, at least

@jsugarman jsugarman added On Hold Temporarily halting blocked and removed Discussion labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked On Hold Temporarily halting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsugarman