Skip to content

Commit

Permalink
test(core): tag render3 test targets as ivy-only (angular#40127)
Browse files Browse the repository at this point in the history
The `render3` test targets are currently also executed for ViewEngine
builds, even though the `render3` infrastructure only concerns Ivy
infrastructure. This commit tags the test targets as ivy-only to disable
those tests for View Engine.

PR Close angular#40127
  • Loading branch information
JoostK authored and josephperrott committed Jan 6, 2021
1 parent 7eadf2e commit 826b77b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions karma-js.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ module.exports = function(config) {
'dist/all/@angular/compiler/test/render3/**',
'dist/all/@angular/core/test/bundling/**',
'dist/all/@angular/core/test/render3/ivy/**',
'dist/all/@angular/core/test/render3/jit/**',
'dist/all/@angular/core/test/render3/perf/**',
'dist/all/@angular/elements/schematics/**',
'dist/all/@angular/examples/**/e2e_test/*',
Expand Down
6 changes: 6 additions & 0 deletions packages/core/test/render3/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ jasmine_node_test(
":domino_es5",
"//tools/testing:node_es5",
],
tags = [
"ivy-only",
],
deps = [
":render3_node_lib",
"//packages/zone.js/lib",
Expand All @@ -88,6 +91,9 @@ jasmine_node_test(

karma_web_test_suite(
name = "render3_web",
tags = [
"ivy-only",
],
deps = [
":render3_lib",
],
Expand Down

0 comments on commit 826b77b

Please sign in to comment.