Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tumblr] attempt to fetch high-quality inline images #2877

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

the-blank-x
Copy link
Contributor

Fixes #1846, and fixes #1344

@Hrxn
Copy link
Contributor

Hrxn commented Aug 30, 2022

Isn't ../s2048x3072/.. the maximum anyway?
Or did they change their site again?

@the-blank-x
Copy link
Contributor Author

What do you mean?

@mikf
Copy link
Owner

mikf commented Aug 30, 2022

Isn't ../s2048x3072/.. the maximum anyway?

Tumblr supports images larger than that. Not entirely sure since when that was a thing again, but this issue from October 2020 talks about downloading a 2874x1761 version of an image, which exceeds 2048x3072.

This post contains a 6400x4000 monochrome PNG and gallery-dl can now actually download that, but only when it's a photo post.

This PR would make it possible to grab higher resolution inline images.

@mikf mikf changed the title [tumblr] attempt to fetch high-quality images (again) [tumblr] attempt to fetch high-quality inline images Aug 30, 2022
@mikf
Copy link
Owner

mikf commented Aug 30, 2022

@the-blank-x would it be OK I personally change some of your code around? I would like to re-structure some of it and explaining this would take quite a bit longer than just doing it myself. (This is a general problem with most PRs, in my opinion, but oh well ...)

Also, are you still allowed to change this PR's title, after I as repo owner edited it?

@the-blank-x
Copy link
Contributor Author

the-blank-x commented Aug 30, 2022

would it be OK I personally change some of your code around?

Sure

are you still allowed to change this PRs title, now that I as repo owner have edited it?

The button is there, but it doesn't work and it seems that the site is broken on my phone

@mikf mikf merged commit 9745b48 into mikf:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants