Windows fixes #74
Windows fixes #74
Conversation
|
@Kayzels I noticed I have broken a feature on osx (the platform I use right now). I will fix it for me, and maybe you could try and see if the windows fixes need some change after that. |
when nvim was editing a file with spaces in its name, it would not be preselected as the current file when opening yazi. This seems like a regression.
|
Doesn't this last commit break the changes for 051bfce, though? I will test it soon. |
|
Yeah I think it did break a bunch of stuff, but it seemed to work now that I tried. I adapted the tests to what seemed to work for me in practice. |
|
So, I'll need to test it now. From what I can tell, you removed the quotes around the input file for Yazi? With that, now the spaces will need to be escaped, so my earlier commit probably won't work. I'll see if there's a way to get it working. |
|
There isn't an easy way to escape spaces in Powershell, so this removal of the quotes is a breaking change. Is there no way to keep them in while still working on Mac? Unfortunately, the tests aren't system agnostic, so changes to make it work for Windows will cause some tests to fail, from what I can see. |
|
Hmm, I think it's possible to keep them on Windows specifically. I pushed a change to hopefully fix this for you. The testing setup doesn't work at all on windows right now 😅 Can you try the latest version out? |
Continuing the work started in #73. Got stalled because of build system issues 🤷🏻♂️