feat: prevent conflicts with custom yazi config for <enter> (opt-in)
#615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue
=====
For custom ways to open files, such as "open in new vertical split",
"open in new tab", etc., yazi.nvim uses the `<enter>` key to open the
file. This is not very robust because the user might have set a custom
keybinding for the `<enter>` key in their yazi config. In this case, the
custom keybinding would be triggered instead of the file being opened.
Solution
========
Instead of relying on the `<enter>` key, yazi.nvim can now use `ya emit
open` to make yazi open the file(s) that are currently selected. This
completely avoids the issue, but requires a recent version of yazi
(0.4.0 or later).
To opt into this behaviour, set the following in your config:
```lua
{
-- example for lazy.nvim
"mikavilpas/yazi.nvim",
-- ... (other settings here) ...
---@type YaziConfig
opts = {
future_features = {
ya_emit_open = true,
-- 👆🏻 this is the new setting
},
},
}
```
This issue was found in
#611 where
smart-enter.yazi was found to have this behaviour by default:
https://github.com/yazi-rs/plugins/tree/main/smart-enter.yazi#advanced
mikavilpas
force-pushed
the
prevent-enter-conflicts
branch
from
6059639 to
8f6276e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
For custom ways to open files, such as "open in new vertical split",
"open in new tab", etc., yazi.nvim uses the
<enter>key to open thefile. This is not very robust because the user might have set a custom
keybinding for the
<enter>key in their yazi config. In this case, thecustom keybinding would be triggered instead of the file being opened.
Solution
Instead of relying on the
<enter>key, yazi.nvim can now useya emit opento make yazi open the file(s) that are currently selected. Thiscompletely avoids the issue, but requires a recent version of yazi
(0.4.0 or later).
To opt into this behaviour, set the following in your config:
{ -- example for lazy.nvim "mikavilpas/yazi.nvim", -- ... (other settings here) ... ---@type YaziConfig opts = { future_features = { ya_emit_open = true, -- 👆🏻 this is the new setting }, }, }This issue was found in
#611 where
smart-enter.yazi was found to have this behaviour by default:
https://github.com/yazi-rs/plugins/tree/main/smart-enter.yazi#advanced