fix: LSP renaming did not work in some cases #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2024
mikavilpas
force-pushed
the
fix-lsp-file-operations
branch
5 times, most recently
from
6150c2f to
d1ceb03
Compare
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80>
mikavilpas
force-pushed
the
fix-lsp-file-operations
branch
from
d1ceb03 to
c53ad9d
Compare
mikavilpas
force-pushed
the
fix-lsp-file-operations
branch
from
e0c5c0e to
ffd5a98
Compare
mikavilpas
added a commit
that referenced
this pull request
Jul 25, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80> This work was started in #190 where the idea is to add a dependency on nvim-lsp-file-operations, but that PR has become slightly stalled for now. This PR is a temporary fix to this stalling by simply embedding the new package inside yazi.nvim for now. When the issues in the PR have been resolved, the embedding can be removed.
mikavilpas
added a commit
that referenced
this pull request
Jul 25, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80> This work was started in #190 where the idea is to add a dependency on nvim-lsp-file-operations, but that PR has become slightly stalled for now. This PR is a temporary fix to this stalling by simply embedding the new package inside yazi.nvim for now. When the issues in the PR have been resolved, the embedding can be removed.
mikavilpas
added a commit
that referenced
this pull request
Jul 25, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80> This work was started in #190 where the idea is to add a dependency on nvim-lsp-file-operations, but that PR has become slightly stalled for now. This PR is a temporary fix to this stalling by simply embedding the new package inside yazi.nvim for now. When the issues in the PR have been resolved, the embedding can be removed.
|
There has been no progress on this effort, so for the time being I have embedded a custom, minimal version of the plugin into yazi.nvim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some edge cases that caused issues when renaming files with
LSP servers. Hopefully fix all of them by using the implementation
that's also shared by neotree and nvim-tree:
https://github.com/antosha417/nvim-lsp-file-operations
Thanks @chaozwn for suggesting the fix!
Closes #80
TODO: