Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null contitional operator to installers.installer.InstallerType #573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheShadowEevee
Copy link

@TheShadowEevee TheShadowEevee commented Dec 29, 2024


  • Adds a Null Conditional Operator to installers.installer.InstallerType.
    • InstallerType is a required field, but is not always defined in the installer list. It may be defined for all lists earlier in the schema, so it should be potentially null here.

Additionally tested against NoMachine.NoMachine (The package I noticed this on) and Microsoft.WindowsSDK.10.0.22621 (The package from #466).

Below screenshots were generated by:

  • Running wingetcreate.exe update Microsoft.WindowsSDK.10.0.22621 -i
  • Feeding in the same Installer URL
  • Responding n then y to keep the manifest and edit it
  • Selecting INSTALLER manifest
  • Selecting Installers property
  • Observing Crash vs No Crash

Microsoft.WindowsSDK.10.0.22621 before this change:
image

Microsoft.WindowsSDK.10.0.22621 after this change:
image

Microsoft Reviewers: Open in CodeFlow

@TheShadowEevee TheShadowEevee requested a review from a team as a code owner December 29, 2024 22:11
@TheShadowEevee TheShadowEevee requested review from yao-msft and ryfu-msft and removed request for a team December 29, 2024 22:11
@yao-msft
Copy link

yao-msft commented Jan 5, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants