Initialize bool type member variables #329
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Could you do a single PR for all prefast issues? This is getting very noisy for me. |
|
Will do! I was grouping them by the warnings. We just had another new one come in, I will ping you once I add a fix for that one as well. |
|
In the past we usually just fixed everything. Otherwise it's so much more work for the dev and reviewer(s). |
|
I realized the new bug is actually for vsixbootstrapper repo, so this PR would be the last one in vswhere for now. We have one last binskim bug to fix in this repo, but the estimated time is longer so we would like to get this one reviewed first. |
heaths
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix C26495 warning flagged by Prefast
Why
Stay compliant with the C++ Core Guidelines and improve code safety by initializing bool type member variables
How
Initialize bool type member variables
Testing
Added unit test for default values