-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix image downloader failing with automl format on deserialize due to missing label transformations #2435
Merged
imatiach-msft
merged 1 commit into
main
from
ilmat/fix-image-downloader-with-automl-format-deserialize
Dec 4, 2023
Merged
fix image downloader failing with automl format on deserialize due to missing label transformations #2435
imatiach-msft
merged 1 commit into
main
from
ilmat/fix-image-downloader-with-automl-format-deserialize
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/fix-image-downloader-with-automl-format-deserialize
branch
2 times, most recently
from
December 1, 2023 18:01
23eb4ec
to
08ab314
Compare
5 similar comments
imatiach-msft
force-pushed
the
ilmat/fix-image-downloader-with-automl-format-deserialize
branch
2 times, most recently
from
December 1, 2023 19:29
0fcf1c3
to
8b124b5
Compare
1 similar comment
imatiach-msft
force-pushed
the
ilmat/fix-image-downloader-with-automl-format-deserialize
branch
from
December 1, 2023 20:02
8b124b5
to
c854a35
Compare
imatiach-msft
force-pushed
the
ilmat/fix-image-downloader-with-automl-format-deserialize
branch
from
December 4, 2023 15:37
c854a35
to
ba48d9a
Compare
imatiach-msft
force-pushed
the
ilmat/fix-image-downloader-with-automl-format-deserialize
branch
from
December 4, 2023 16:45
ba48d9a
to
7af64fe
Compare
tongyu-microsoft
approved these changes
Dec 4, 2023
1 similar comment
imatiach-msft
force-pushed
the
ilmat/fix-image-downloader-with-automl-format-deserialize
branch
from
December 4, 2023 20:22
513c6ab
to
117f658
Compare
… missing label transformations
imatiach-msft
deleted the
ilmat/fix-image-downloader-with-automl-format-deserialize
branch
December 4, 2023 22:46
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix image downloader failing with automl format on deserialize due to missing label transformations
Seeing errors when deserializing RAIVisionInsights with automl format labels:
After extensive debugging, we discovered this was in the deserializer for true_y labels when image downloader is specified and the test dataset is reset, but the labels are not converted, which we could confirm based on the printed labels when adding debug:
The first two detections are in the converted common format for predicted labels. The third detection is for the true_y labels and is in the automl format and was not transformed. Transforming the labels on deserialize fixed the error.
Also new tests for object detection serialize + deserialize were added as part of this PR, which only previously existed for other tasks like image classification.
Checklist