Object Detection Model Overview missing-class fix for Cohorts #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advitya17
changed the title
Advitya17
requested review from
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
imatiach-msft
approved these changes
Nov 28, 2023
…oft/responsible-ai-toolbox into agemawat/cohort_class_fix
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2429 +/- ##
==========================================
- Coverage 88.86% 81.01% -7.85%
==========================================
Files 134 26 -108
Lines 7708 2297 -5411
==========================================
- Hits 6850 1861 -4989
+ Misses 858 436 -422
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of the endpoint involved getting a single list of missing class names for the first created cohort. However, there may be different missing class names for different cohorts. This PR fixes this issue by returning lists of different missing classes in the order of the computed cohorts.
Copilot-created summary:
The most important changes include modifying the
compute_object_detection_metricsfunction inrai_vision_insights.pyto handle cases where a class is not present in the cohort, and ensuring the correct class name is used for comparison inModelOverview.tsx.Main functionality changes:
rai_vision_insights.py: Modified thecompute_object_detection_metricsfunction to include a new listall_cohort_classesto store the classes for each cohort, return bothall_cohort_metricsandall_cohort_classes, and handle cases where a class is not present in the cohort. [1] [2] [3]Correctness improvement:
ModelOverview.tsx: Ensured that the correct class name is used for comparison withthis.state.classNamein the loop.Description
Checklist