OD Explanation Loader Fix (#2381)

* ckpt * ternary condition fix * auto lint fixes
microsoft · Oct 26, 2023 · e4487bf · e4487bf
1 parent 3a5541d
commit e4487bf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/FlyoutObjectDetection.tsx b/libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/FlyoutObjectDetection.tsx
@@ -198,7 +198,7 @@ export class FlyoutObjectDetection extends React.Component<
                     +this.state.odSelectedKey.slice(
                       FlyoutODUtils.ExcessLabelLen
                     )
-                  ] ? (
+                  ] && (
                     <FluentUI.Stack.Item className={classNames.imageContainer}>
                       <FluentUI.Image
                         src={`data:image/jpg;base64,${this.props.explanations
@@ -212,13 +212,19 @@ export class FlyoutObjectDetection extends React.Component<
                         style={explanationImage}
                       />
                     </FluentUI.Stack.Item>
-                  ) : (
-                    <FluentUI.Stack.Item>
-                      <FluentUI.Spinner
-                        label={`${localization.InterpretVision.Dashboard.loading} ${item?.index}`}
-                      />
-                    </FluentUI.Stack.Item>
                   )}
+                  {this.state.odSelectedKey !== "" &&
+                    this.props.loadingExplanation[item.index][
+                      +this.state.odSelectedKey.slice(
+                        FlyoutODUtils.ExcessLabelLen
+                      )
+                    ] && (
+                      <FluentUI.Stack.Item>
+                        <FluentUI.Spinner
+                          label={`${localization.InterpretVision.Dashboard.loading} ${item?.index}`}
+                        />
+                      </FluentUI.Stack.Item>
+                    )}
                 </FluentUI.Stack>
               </FluentUI.Stack>
             </FluentUI.Stack>

diff --git a/libs/localization/src/lib/en.json b/libs/localization/src/lib/en.json
@@ -1449,7 +1449,7 @@
       "labelVisibilityDropdown": "Select labels to display",
       "legendFailure": "failure",
       "legendSuccess": "success",
-      "loading": "Computing explanation for index",
+      "loading": "Computing explanation for image of index",
       "multiselect": "Multiselect",
       "notdefined": "object scenario not defined",
       "objectSelect": "Object Selection",