Support further Python Interop for callables in .estimate(), .compile(), .run() and .circuit()
#2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpilation This follows up on #2054 by adding the enhanced support for Q# callables exposed into Python and Python argument arrays in resource estimation and QIR compilation.
swernli
requested review from
billti,
ivanbasov,
idavis and
minestarks
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
swernli
commented
Jan 7, 2025
minestarks
reviewed
Jan 7, 2025
pip/src/interpreter.rs
Outdated
There was a problem hiding this comment.
What about the third sibling, .run() ? I think it would make sense to allow that to take a callable, as well.
And of course, there's .circuit(), which can already take a callable, but uses a different pattern... which is unfortunate, because this new pattern is better. I wouldn't be opposed to updating .circuit() to allow the new pattern as well, but I understand if you don't want to touch it in this PR.
There was a problem hiding this comment.
I think it's worth updating both of those. I'll get that added and see how it looks.
There was a problem hiding this comment.
I've added the support for .run() and .circuit(), let me know what you think!
idavis
reviewed
Jan 8, 2025
idavis
reviewed
Jan 8, 2025
swernli
changed the title
.estimate(), .compile(), .run() and .circuit()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #2054 by adding the enhanced support for Q# callables exposed into Python and Python argument arrays in resource estimation, QIR compilation, running multiple shots, and circuit generation.