-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simple VQE sample #2073
base: main
Are you sure you want to change the base?
Added simple VQE sample #2073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, left some comments.
/// This is an example of a Variational Quantum Eigensolver (VQE). | ||
/// This example includes: | ||
/// 1. Simple classical optimization to find minimum of a multi-variable function | ||
/// in order to find an approximation to the minimum eigenvalue of a hamiltonian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: "Hamiltonian" should be capitalized here, I think
/// in order to find an approximation to the minimum eigenvalue of a hamiltonian | |
/// in order to find an approximation to the minimum eigenvalue of a Hamiltonian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong on this, but if not, it might be worth fixing in the comments throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; I think it would be worth adding it to the samples.mjs that controls which samples show up in the editor!
This PR adds simple self-contained example of a Variational Quantum Eigensolver (VQE).
This example includes:
To keep this sample simple and self-contained Hamiltonian is artificial (doesn't correspond to any actual chemistry problem). Also, this sample doesn't include any application of VQE, for example, finding a geometry of a molecule.