devops: show package names instead of missing libs on Ubuntu 18.04 #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
force-pushed
the
packages-to-install
branch
from
92abf0c to
b6639ed
Compare
yury-s
approved these changes
Jul 17, 2020
src/server/validateDependencies.ts
Outdated
| // Check Ubuntu version. | ||
| const missingPackages = new Set(); | ||
| const osRelease = await readFileAsync('/etc/os-release', 'utf8').catch(e => ''); | ||
| const [ubuntuName = '', ubuntuVersion = ''] = osRelease.trim().split('\n'); |
There was a problem hiding this comment.
Is the order of entries actually predefined? Not a big deal but using a map could be more reliable.
There was a problem hiding this comment.
fair enough. Done.
src/server/validateDependencies.ts
Outdated
| if (missingPackages.size) { | ||
| missingPackagesMessage = [ | ||
| ` Install missing packages with:`, | ||
| ` apt-get install -y ${[...missingPackages].join('\\\n ')}`, |
There was a problem hiding this comment.
removed -y instead as per offline discussion
This patch starts putting package names to install on Ubuntu instead of missing dependencies list. The mapping of library to package name is obtained using the following script: https://gist.github.com/aslushnikov/2766200430228c3700537292fccad064 References microsoft#2745
aslushnikov
force-pushed
the
packages-to-install
branch
from
733e6e5 to
c976048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts putting package names to install on Ubuntu instead
of missing dependencies list.
The mapping of library to package name is obtained using the following
script: https://gist.github.com/aslushnikov/2766200430228c3700537292fccad064
References #2745