Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail workflow if msiexec returns failure #143

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

Alan-Jowett
Copy link
Member

Warn if uninstall of eBPF or XDP fails.
Fail the workflow if install of eBPF or XDP fails.

Copy link
Collaborator

@ProjectsByJackHe ProjectsByJackHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing on failure of uninstall is a good idea. Sorry about the current garbage collection situation.

Signed-off-by: Alan Jowett <[email protected]>
Alan Jowett added 2 commits April 3, 2024 14:10
When MSI is not installed, fails with:
`This action is only valid for products that are currently installed.`

Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
@Alan-Jowett Alan-Jowett merged commit a877b16 into microsoft:main Apr 11, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants