Standard SecNetPerf Scenarios #4607
Conversation
scripts/secnetperf.ps1
Outdated
| $allTests["hps-conns-100"] = "-exec:maxtput -rconn:1 -share:1 -conns:100 -run:12s -prate:1" | ||
| $allTests["rps-up-512-down-4000"] = "-exec:lowlat -rstream:1 -up:512 -down:4000 -run:20s -plat:1" | ||
| $allTests["max-rps-up-512-down-4000"] = "-exec:lowlat -conns:16cpu -streams:10 -rstream:1 -up:512 -down:4000 -run:20s -plat:1" | ||
| $allTests = @("upload", "download", "hps", "rps-single", "rps-multi", "latency") |
There was a problem hiding this comment.
I think this is effectively a breaking change, from an identifier tput-up to upload (and so on), and I might need to keep the old ID and map it to the scenario. @ProjectsByJackHe please let me know what you think.
There was a problem hiding this comment.
@ProjectsByJackHe as we discussed in our meeting yesterday, we need to ensure we're Ok with this change, and then update the dashboard and other netperf files as necessary. Please take a look. Thanks!
There was a problem hiding this comment.
Tracking: microsoft/netperf#401
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
==========================================
- Coverage 86.98% 85.87% -1.12%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15096 14903 -193
- Misses 2258 2451 +193 ☔ View full report in Codecov by Sentry. |
|
@ProjectsByJackHe where are we on this? Is netperf ready to merge this? |
Doing some local dry runs to ensure these changes do not break compatibility. Tracking: microsoft/netperf#401 |
|
|
||
| $hasFailures = $false | ||
| $json["run_args"] = $allTests |
There was a problem hiding this comment.
Hmm, if netperf will always use the default options (stream count, connection count...) for each scenario, then this is fine. But otherwise, we might still need this.
Almost ready for merge! Once microsoft/netperf#414 gets merged first, validation passes, then this PR is ready for merge. |
This reverts commit 3eb3fe0.
| @@ -304,7 +304,7 @@ IsValue( | |||
| _In_z_ const char* toTestAgainst | |||
| ) | |||
| { | |||
| return _strnicmp(name, toTestAgainst, CXPLAT_MIN(strlen(name), strlen(toTestAgainst))) == 0; | |||
| return _strnicmp(name, toTestAgainst, strlen(toTestAgainst)) == 0; | |||
There was a problem hiding this comment.
Why was this change made?
There was a problem hiding this comment.
We wanted to do an exact match, not just on the shortest part. This is because we're using some of the same prefix and we don't want incorrect matches.
Description
Adds a new secnetperf cmd line arg
-scenario:which standardizes a few common test cases. This then simplifies the secnetperf scripts for netperf to just use these scenarios.Testing
CI/CD
Documentation
Updated help text