Highlight JSX in TypeScript. #4650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, this reformatted the file. Not sure why, but it's better this way anyway.
shihui-huang
reviewed
Nov 6, 2024
| ], | ||
|
|
||
| jsxOpen: [ | ||
| [/{/, { token: 'keyword', next: '@root.INJSX', bracket: '@open' }], |
There was a problem hiding this comment.
Hi @thesoftwarephilosopher, Thank you so much for sharing this token provider file. It's very helpful and straightforward, and it solved my problem very easily!
I noticed a small inconsistency where the first and second brackets had different tokens in some cases. I made a slight modification to make them consistent.
Before:
After:
Suggested change
| [/{/, { token: 'keyword', next: '@root.INJSX', bracket: '@open' }], | |
| [/{/, { token: 'delimiter.curly', next: '@root.INJSX', bracket: '@open' }], |
| ], | ||
|
|
||
| jsxText: [ | ||
| [/{/, { token: 'keyword', next: '@root.INJSX', bracket: '@open' }], |
There was a problem hiding this comment.
Suggested change
| [/{/, { token: 'keyword', next: '@root.INJSX', bracket: '@open' }], | |
| [/{/, { token: 'delimiter.curly', next: '@root.INJSX', bracket: '@open' }], |
| [/@escapes/, 'string.escape'], | ||
| [/\\./, 'string.escape.invalid'], | ||
| [/`/, 'string', '@pop'] | ||
| [/\.\.\./, 'keyword'], |
There was a problem hiding this comment.
And I think it would be more fitting to categorize ... as an operator
|
Hey, is there any followup to this PR? @thesoftwarephilosopher |
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JSX highlighting to TypeScript natively using Monaco's Monarch tokenizer, along with a few other nice to have changes:
...as a keywordexport/etcas control-flow keywordsIt has been thoroughly tested on https://vanillajsx.com/monarch/ but it would be useful to have more people test for edge cases.
A few unrelated tests are failing such as PHP and Less, which I don't understand how they're related since my code is isolated to one file. The failures look to just be whitespace errors, but it's hard to tell.
I didn't update the TypeScript tests yet, so they're failing too.