Add SHA512-224 and SHA512-256 support for OpenSSL backend and implement its methods in other backends #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertakman
requested review from
microsoft-golang-review-bot and
a team
as code owners
mertakman
force-pushed
the
add-sha512-224-256-openssl
branch
from
6800180 to
f979797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently failing to build. Following the merge of golang-fips/openssl#240, a go.mod update is required. This PR focuses solely on the changes unrelated to the necessary go.mod update.
When merged , it fixes #1456
Also this PR renames the Ed25519, previously it was miswritten as Ed25119, but this pr fixed.