Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial implementation of macOS crypto backend #1453

Open
wants to merge 7 commits into
base: microsoft/main
Choose a base branch
from
Open

initial implementation of macOS crypto backend #1453

wants to merge 7 commits into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Dec 18, 2024 •
edited
Loading

closes: #1013

@gdams gdams force-pushed the dev/gadams/darwincrypto branch 7 times, most recently from daa02a7 to f092c70 Compare December 20, 2024 20:27
@gdams gdams force-pushed the dev/gadams/darwincrypto branch 16 times, most recently from 2f2b6d7 to c9eda5b Compare January 8, 2025 16:33
@dagood
Copy link
Member

dagood commented Jan 8, 2025

Filed actions/runner-images#11331 about the GOROOT workaround on macOS.

@dagood
Copy link
Member

dagood commented Jan 8, 2025

Now, test failures.

@gdams gdams force-pushed the dev/gadams/darwincrypto branch 5 times, most recently from d45bb85 to 2dfa2d3 Compare January 9, 2025 09:51
@gdams gdams added the new-platform Support a platform new to the microsoft/go infrastructure label Jan 9, 2025
@gdams gdams force-pushed the dev/gadams/darwincrypto branch from ec7b192 to 0fbdaca Compare January 9, 2025 10:51
@gdams gdams marked this pull request as ready for review January 9, 2025 10:54
@gdams gdams requested review from qmuntal, dagood and mertakman January 9, 2025 10:55
@gdams gdams force-pushed the dev/gadams/darwincrypto branch from 0fbdaca to 6e15345 Compare January 9, 2025 12:33
@gdams gdams force-pushed the dev/gadams/darwincrypto branch from 6e15345 to 8bd9fd4 Compare January 9, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-golang-review-bot microsoft-golang-review-bot Awaiting requested review from microsoft-golang-review-bot microsoft-golang-review-bot is a code owner

@qmuntal qmuntal Awaiting requested review from qmuntal

@dagood dagood Awaiting requested review from dagood

@mertakman mertakman Awaiting requested review from mertakman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new-platform Support a platform new to the microsoft/go infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider FIPS support on macOS / darwin
2 participants
@gdams @dagood