Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of JWT Issuer port #285

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow setting of JWT Issuer port #285

wants to merge 2 commits into from

Conversation

DomAyre
Copy link
Collaborator

@DomAyre DomAyre commented Jan 9, 2025

Motivation

Since #266, the test JWT issuer doesn't use a fixed port, privacy-sandbox-dev assumes it does which breaks it's testing.
To fix this the options are to either:

  • Allow setting the port of the JWT issuer to the port assumed by privacy-sandbox-dev
  • Read the full address in privacy-sandbox-dev

Since privacy-sandbox-dev assumes the port in many places (including in an instance running in ACI) it's non-trivial to do the first change, so opting for the latter.

Changes

  • Update test JWT Issuer implementation to use the value of JWT_ISSUER_PORT as the port if set (default to 0 if unset)
  • Pass that env variable into the JWT issuer container image in docker compose
  • Set that value to 3000 for the standalone image used by privacy-sandbox-dev

@DomAyre
Copy link
Collaborator Author

DomAyre commented Jan 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant