Self review

microsoft · Dec 5, 2024 · 88adf65 · 88adf65
1 parent c9e6f63
commit 88adf65
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 3 deletions.
diff --git a/__tests__/html2/markdown/math/layout.spec.html.snap-1.png b/__tests__/html2/markdown/math/layout.spec.html.snap-1.png
diff --git a/__tests__/html2/markdown/math/layout.spec.html.snap-2.png b/__tests__/html2/markdown/math/layout.spec.html.snap-2.png
diff --git a/__tests__/html2/markdown/math/layout.spec.html.snap-3.png b/__tests__/html2/markdown/math/layout.spec.html.snap-3.png
diff --git a/packages/bundle/src/codeHighlighter/ShikiComposer.tsx b/packages/bundle/src/codeHighlighter/ShikiComposer.tsx
@@ -1,7 +1,8 @@
+import { CodeHighlighterComposer, type HighlightCodeFn } from 'botframework-webchat-component/internal';
 import React, { memo, ReactNode, useEffect, useState } from 'react';
 import { type HighlighterCore } from 'shiki';
+
 import createHighlighter from './shiki';
-import { CodeHighlighterComposer, type HighlightCodeFn } from 'botframework-webchat-component/internal';
 
 const createHighligtCodeWithShiki =
   (shikiHiglighter: HighlighterCore): HighlightCodeFn =>

diff --git a/packages/component/src/Attachment/Text/private/CodeContent.tsx b/packages/component/src/Attachment/Text/private/CodeContent.tsx
@@ -1,5 +1,6 @@
 import classNames from 'classnames';
 import React, { Fragment, memo, ReactNode } from 'react';
+
 import useCodeBlockTag from '../../../providers/CustomElements/useCodeBlockTagName';
 
 type Props = Readonly<{

diff --git a/packages/component/src/providers/CustomElements/CustomElementsComposer.tsx b/packages/component/src/providers/CustomElements/CustomElementsComposer.tsx
@@ -1,8 +1,9 @@
 import mathRandom from 'math-random';
 import React, { memo, useCallback, useMemo, type ReactNode } from 'react';
+
+import useReactCodeBlockClass from './customElements/CodeBlock';
 import { CodeBlockCopyButtonElement } from './customElements/CodeBlockCopyButton';
 import CustomElementsContext from './private/CustomElementsContext';
-import useReactCodeBlockClass from './customElements/CodeBlock';
 
 type CustomElementsComposerProps = Readonly<{
   children?: ReactNode | undefined;

diff --git a/packages/component/src/providers/CustomElements/customElements/CodeBlock.ts b/packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
@@ -148,6 +148,7 @@ const createReactCodeBlockClass = ({
 
     disconnectedCallback() {
       this.#controller?.abort();
+      this.#controller = null;
     }
 
     highlight(...args: Parameters<HighlightCodeFn>) {

diff --git a/packages/component/src/providers/CustomElements/customElements/CodeBlockCopyButton.tsx b/packages/component/src/providers/CustomElements/customElements/CodeBlockCopyButton.tsx
@@ -2,6 +2,7 @@ import classNames from 'classnames';
 import React, { memo, useCallback, useState, type MouseEventHandler } from 'react';
 import { useRefFrom } from 'use-ref-from';
 import { useStateWithRef } from 'use-state-with-ref';
+
 import testIds from '../../../testIds';
 import wrapAsCustomElement from './wrapAsCustomElement';
 

diff --git a/packages/component/src/providers/CustomElements/private/useUpdater.tsx b/packages/component/src/providers/CustomElements/private/useUpdater.tsx
@@ -1,4 +1,4 @@
-import { useMemo, useRef, useCallback, type DependencyList, type RefObject } from 'react';
+import { useCallback, useMemo, useRef, type DependencyList, type RefObject } from 'react';
 
 export type UpdateFn = () => any;
 export type OnTrackFn = (cb: UpdateFn, signal: AbortSignal) => void;