Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Commit

Permalink
Special-case display of "LSTM" name
Browse files Browse the repository at this point in the history
because of #143

Eventually we plan to change to a standard LSTM formulation
  • Loading branch information
toelli-msft committed Oct 30, 2019
1 parent 6d21c40 commit bfb9818
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion ADBench/plot_graphs.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def graph_data(build_type, objective, maybe_test_size, function_type):

test_size = ", ".join([utils.cap_str(s) for s in maybe_test_size[0].split("_")]) if len(maybe_test_size) == 1 else None
has_ts = test_size is not None
graph_name = (f"{objective.upper()}" +
graph_name = (f"{objective_display_name(objective)}" +
(f" ({test_size})" if has_ts else "") +
f" [{function_type.capitalize()}] - {build_type}")
graph_save_location = os.path.join(build_type, function_type, f"{graph_name} Graph")
Expand All @@ -85,6 +85,18 @@ def graph_data(build_type, objective, maybe_test_size, function_type):

return (graph_name, graph_save_location)

# What we call LSTM is not quite a full LSTM. Rather it's an LSTM
# with diagonal weight matrices. We don't want to be misleading so we
# rename the graph. Eventually we will implement a full LSTM and we
# will remove this special case. See
#
# https://github.com/awf/ADBench/issues/143
def objective_display_name(objective):
if objective.upper() == "LSTM":
return "D-LSTM"
else:
return objective.upper()

has_manual = lambda tool: tool.lower() in ["manual", "manual_eigen"]

def tool_names(graph_files):
Expand Down

0 comments on commit bfb9818

Please sign in to comment.