Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve export bugs #300

Merged
merged 5 commits into from
May 3, 2024
Merged

fix: resolve export bugs #300

merged 5 commits into from
May 3, 2024

Conversation

LiliumCandidum
Copy link
Collaborator

@LiliumCandidum LiliumCandidum commented May 3, 2024 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

This pull request resolves two bugs related to GET /export:

  1. When exporting data as csv file, sometimes some fields weren't included in the response
  2. When exporting data as excel file, the response always included all the fields of a collection even if _p or _rawp were specified

PR Checklist

  • The commit message follows our guidelines included in the CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@LiliumCandidum LiliumCandidum requested a review from danibix95 May 3, 2024 14:45
danibix95
danibix95 approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@danibix95 danibix95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/upsertOne.test.js Outdated Show resolved Hide resolved
@danibix95 danibix95 changed the title Fix export bugs fix: resolve export bugs May 3, 2024
@danibix95 danibix95 merged commit a95961d into main May 3, 2024
10 of 11 checks passed
@danibix95 danibix95 deleted the comp-276-fix-export-bugs branch May 3, 2024 15:45
@danibix95 danibix95 mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danibix95 danibix95 danibix95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiliumCandidum @danibix95