Apply code analyzer suggestions

src/Menees.Remoting/Json/ReadOnlyDictionaryConverter.cs

@@ -96,7 +96,7 @@ private class ReadOnlyDictionaryConverterInner<TKey, TValue> : JsonConverter<IRe
 					typeToConvert,
 					BindingFlags.Instance | BindingFlags.Public,
 					binder: null,
-					args: new object[] { dictionary },
+					args: [dictionary],
 					culture: null);
 			}
 

src/Menees.Remoting/MessageClient.cs

@@ -93,7 +93,7 @@ public async Task<TOut> SendAsync(TIn message, CancellationToken cancellationTok
 	{
 		Request request = new()
 		{
-			Arguments = new() { new UserSerializedValue(typeof(TIn), message, this.UserSerializer) },
+			Arguments = [new UserSerializedValue(typeof(TIn), message, this.UserSerializer)],
 		};
 
 		Response? response = null;

src/Menees.Remoting/Models/ServiceError.cs

@@ -74,10 +74,10 @@ private Exception CreateException()
 		// Try to throw a new exception of the requested type. The new exception's StackTrace will be from the client,
 		// but its message, data type, and inner exception will match the server's exception info.
 		Exception result;
-		ConstructorInfo? constructor = this.ExceptionType.GetConstructor(new[] { typeof(string), typeof(Exception) });
+		ConstructorInfo? constructor = this.ExceptionType.GetConstructor([typeof(string), typeof(Exception)]);
 		if (constructor != null)
 		{
-			result = (Exception)constructor.Invoke(new object?[] { this.Message, innerException });
+			result = (Exception)constructor.Invoke([this.Message, innerException]);
 		}
 		else
 		{

src/Menees.Remoting/Pipes/PipeClient.cs

@@ -13,7 +13,7 @@ internal sealed class PipeClient : PipeNode
 	#region Private Data Members
 
 #pragma warning disable SA1310 // Field names should not contain underscore. Named like WinError.h constant.
-	private const int ERROR_SEM_TIMEOUT = unchecked((int)0x80070079);
+	private const int ERROR_SEM_TIMEOUT = unchecked((int)0x80_07_00_79);
 #pragma warning restore SA1310 // Field names should not contain underscore
 
 	private readonly PipeClientSecurity? security;

src/Menees.Remoting/Pipes/PipeServer.cs

@@ -11,7 +11,7 @@ internal sealed class PipeServer : PipeNode
 {
 	#region Private Data Members
 
-	private readonly HashSet<PipeServerListener> listeners = new();
+	private readonly HashSet<PipeServerListener> listeners = [];
 	private readonly int minListeners;
 	private readonly int maxListeners;
 	private readonly IServer server;

src/Menees.Remoting/RmiServer.cs

@@ -135,7 +135,7 @@ protected override void Dispose(bool disposing)
 
 	private static Dictionary<string, MethodInfo> CreateMethodSignatureDictionary()
 	{
-		List<(string Signature, MethodInfo Method)> items = new();
+		List<(string Signature, MethodInfo Method)> items = [];
 
 		void AddMethods(Type interfaceType)
 		{

src/Menees.Remoting/ServerHost.cs

@@ -15,7 +15,7 @@ public sealed class ServerHost : IServerHost, IDisposable
 	#region Private Data Members
 
 	private readonly ManualResetEventSlim resetEvent = new(false);
-	private readonly HashSet<IServer> servers = new();
+	private readonly HashSet<IServer> servers = [];
 	private bool isDisposed;
 	private bool isExiting;
 

tests/Menees.Remoting.Tests/BaseTests.cs

@@ -149,12 +149,12 @@ private protected static void TestProxy(ITester testerProxy, int testId, bool is
 		Widget paper = testerProxy.CreateWidget("Paper", 0.01m, 85, 110);
 		paper.Name.ShouldBe("Paper");
 		paper.Cost.ShouldBe(0.01m);
-		paper.Dimensions.ShouldBe(new[] { 85, 110 });
+		paper.Dimensions.ShouldBe([85, 110]);
 
 		paper = testerProxy.UpdateWidget(paper, "Fancy Paper", 0.02m, null);
 		paper.Name.ShouldBe("Fancy Paper");
 		paper.Cost.ShouldBe(0.02m);
-		paper.Dimensions.ShouldBe(new[] { 85, 110 });
+		paper.Dimensions.ShouldBe([85, 110]);
 	}
 
 	private protected static void WriteUnhandledServerException(Exception ex)
@@ -168,12 +168,14 @@ private static void InitializeProcessStartInfo(Type hostProgram, out ProcessStar
 	{
 		string hostExeLocation = hostProgram.Assembly.Location;
 
-		startInfo = new();
-		startInfo.CreateNoWindow = true;
-		startInfo.WindowStyle = ProcessWindowStyle.Hidden;
-		startInfo.ErrorDialog = false;
+		startInfo = new()
+		{
+			CreateNoWindow = true,
+			WindowStyle = ProcessWindowStyle.Hidden,
+			ErrorDialog = false,
+		};
 
-		arguments = new();
+		arguments = [];
 		if (string.Equals(Path.GetExtension(hostExeLocation), ".exe", StringComparison.OrdinalIgnoreCase))
 		{
 			startInfo.FileName = Path.GetFileName(hostExeLocation);

tests/Menees.Remoting.Tests/MessageNodeTests.cs

@@ -24,7 +24,7 @@ public async Task Base64ExampleAsync()
 		server.Start();
 
 		using MessageClient<byte[], string> client = new(ServerPath);
-		string response = await client.SendAsync(new byte[] { 1, 2, 3, 4 }).ConfigureAwait(false);
+		string response = await client.SendAsync([1, 2, 3, 4]).ConfigureAwait(false);
 		response.ShouldBe("AQIDBA==");
 	}
 

tests/Menees.Remoting.Tests/RmiClientTests.cs

@@ -16,7 +16,7 @@ public void HasherExample()
 		using RmiClient<IHasher> client = new(ServerPath);
 		IHasher proxy = client.CreateProxy();
 
-		proxy.Hash(new byte[] { 1, 2, 3, 4 }).Length.ShouldBe(20);
+		proxy.Hash([1, 2, 3, 4]).Length.ShouldBe(20);
 		proxy.Hash("Testing").ShouldBe("0820b32b206b7352858e8903a838ed14319acdfd");
 	}