Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Js.String2, use labeled arguments for Js.String #893

Merged
merged 6 commits into from
Nov 16, 2023
Merged

feat: remove Js.String2, use labeled arguments for Js.String #893

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7db5dce
feat: remove Js.String2, use labeled arguments for Js.String
anmonteiro Nov 15, 2023
62162d4
chore: add changelog entry for #893 and #895
anmonteiro Nov 15, 2023
d1d5d0d
code review, fix tests
anmonteiro Nov 16, 2023
ce2b3f6
Merge remote-tracking branch 'origin/main' into anmonteiro/migrate-st…
anmonteiro Nov 16, 2023
34846d5
fix: ci
anmonteiro Nov 16, 2023
f8ea2f0
more code review fixes
anmonteiro Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ Unreleased
1. Exception ID `RE_EXN_ID` to `MEL_EXN_ID`
2. `BS_PRIVATE_NESTED_SOME_NONE` option marker to
`MEL_PRIVATE_NESTED_SOME_NONE`
- BREAKING(runtime): unify pipe-first / pipe-last libraries in `Js` modules
([#731](https://github.com/melange-re/melange/issues/731),
[#893](https://github.com/melange-re/melange/pull/893),
[#895](https://github.com/melange-re/melange/pull/895))
- Modules ending with `2` (e.g. `Js.String2`, `Js.Array2`) are no longer
available in Melange
- The functions in their corresponding modules now take labeled arguments,
allowing them to be used with both `|.` and `|>`.
- Consistently handle empty payloads in externals:
([#852](https://github.com/melange-re/melange/pull/852))
- Fix crash when pattern matching in the presence of complex constant inlining
Expand Down
3 changes: 0 additions & 3 deletions jscomp/runtime/js.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@ module Nullable = Js_null_undefined
module Array = Js_array
(** Provide bindings to Js array*)

module String2 = Js_string2
(** Provide bindings to JS string *)

module Re = Js_re
(** Provide bindings to Js regex expression *)

Expand Down
712 changes: 377 additions & 335 deletions jscomp/runtime/js_string.ml
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading