generated JS: fix for loop formatting (#1296)

* generated JS: fix `for` loop formatting * snapshot runtime tests * add changelog entry
melange-re · Jan 14, 2025 · 8ec534d · 8ec534d
1 parent 9669dc8
commit 8ec534d
Show file tree

Hide file tree

Showing 27 changed files with 81 additions and 79 deletions.
diff --git a/Changes.md b/Changes.md
@@ -95,6 +95,8 @@ Unreleased
   ([#1287](https://github.com/melange-re/melange/pull/1287))
 - JS generation: remove redundant switch cases branches
   ([#1295](https://github.com/melange-re/melange/pull/1295))
+- JS generation: move space before comma inside `for` definition
+  ([#1296](https://github.com/melange-re/melange/pull/1296))
 
 4.0.1 2024-06-07
 ---------------

diff --git a/jscomp/core/js_dump.ml b/jscomp/core/js_dump.ml
@@ -1113,8 +1113,8 @@ and statement_desc top cxt (s : J.statement_desc) : cxt =
                             let cxt =
                               expression ~level:1 cxt ident_expression
                             in
-                            space cxt;
                             comma cxt;
+                            space cxt;
                             let id = Ident.create (Ident.name id ^ "_finish") in
                             let cxt = ident cxt id in
                             space cxt;

diff --git a/jscomp/test/dist/jscomp/test/bdd.js b/jscomp/test/dist/jscomp/test/bdd.js
diff --git a/jscomp/test/dist/jscomp/test/bench.js b/jscomp/test/dist/jscomp/test/bench.js
diff --git a/jscomp/test/dist/jscomp/test/bs_mutable_set_test.js b/jscomp/test/dist/jscomp/test/bs_mutable_set_test.js
diff --git a/jscomp/test/dist/jscomp/test/bs_poly_mutable_set_test.js b/jscomp/test/dist/jscomp/test/bs_poly_mutable_set_test.js
diff --git a/jscomp/test/dist/jscomp/test/class_type_ffi_test.js b/jscomp/test/dist/jscomp/test/class_type_ffi_test.js
diff --git a/jscomp/test/dist/jscomp/test/complex_if_test.js b/jscomp/test/dist/jscomp/test/complex_if_test.js
diff --git a/jscomp/test/dist/jscomp/test/earger_curry_test.js b/jscomp/test/dist/jscomp/test/earger_curry_test.js
diff --git a/jscomp/test/dist/jscomp/test/ext_array_test.js b/jscomp/test/dist/jscomp/test/ext_array_test.js
diff --git a/jscomp/test/dist/jscomp/test/ext_bytes_test.js b/jscomp/test/dist/jscomp/test/ext_bytes_test.js
diff --git a/jscomp/test/dist/jscomp/test/ext_pervasives_test.js b/jscomp/test/dist/jscomp/test/ext_pervasives_test.js
diff --git a/jscomp/test/dist/jscomp/test/flexible_array_test.js b/jscomp/test/dist/jscomp/test/flexible_array_test.js
diff --git a/jscomp/test/dist/jscomp/test/for_loop_test.js b/jscomp/test/dist/jscomp/test/for_loop_test.js
diff --git a/jscomp/test/dist/jscomp/test/for_side_effect_test.js b/jscomp/test/dist/jscomp/test/for_side_effect_test.js
diff --git a/jscomp/test/dist/jscomp/test/imm_map_bench.js b/jscomp/test/dist/jscomp/test/imm_map_bench.js
diff --git a/jscomp/test/dist/jscomp/test/int_overflow_test.js b/jscomp/test/dist/jscomp/test/int_overflow_test.js
diff --git a/jscomp/test/dist/jscomp/test/ocaml_parsetree_test.js b/jscomp/test/dist/jscomp/test/ocaml_parsetree_test.js
diff --git a/jscomp/test/dist/jscomp/test/ocaml_re_test.js b/jscomp/test/dist/jscomp/test/ocaml_re_test.js