-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/CV2-5785: media dialog view ux updates to include media match reason #2256
Open
danielevalverde
wants to merge
12
commits into
epic/CV2-5510-why-media-is-in-cluster
Choose a base branch
from
feature/CV2-5785-media-dialog-view-ux-updates-to-include-media-match-reason
base: epic/CV2-5510-why-media-is-in-cluster
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4afa1b8
adding MediaOriginBanner component to media page
danielevalverde 1823f14
passing media_clust_relantioship props
danielevalverde 1227945
refactoring and renaming props
danielevalverde ea3b53f
more code cleanup
danielevalverde 8954e9d
remove component from sandbox
danielevalverde 567950f
updating unit tests
danielevalverde 0053975
Fix linter problems
danielevalverde da5c700
apply PR review
danielevalverde a579be2
remove more debugs
danielevalverde 582c346
apply PR programing with Alex
danielevalverde ad7b79d
update tests
danielevalverde 47bb428
add MediaOriginBanner to MediaComponent
danielevalverde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,6 +115,10 @@ const MediaOriginBanner = ({ | |
); | ||
}; | ||
|
||
MediaOriginBanner.defaultProps = { | ||
media_cluster_relationship: {}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prop names should follow camelCase |
||
}; | ||
|
||
MediaOriginBanner.propTypes = { | ||
media_cluster_origin: PropTypes.number.isRequired, | ||
media_cluster_origin_timestamp: PropTypes.number.isRequired, | ||
|
@@ -126,7 +130,7 @@ MediaOriginBanner.propTypes = { | |
target: PropTypes.shape({ | ||
title: PropTypes.string, | ||
}), | ||
}).isRequired, | ||
}), | ||
}; | ||
|
||
export default MediaOriginBanner; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prop names should follow
camelCase
=>mediaOriginBanner={