Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5978 convert DrawerNavigation to relay modern #2250

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

sarahkeh
Copy link
Contributor

@sarahkeh sarahkeh commented Jan 15, 2025

  • QueryRenderer replaces DrawerRail's relay classic query
  • QueryRenderer replaces DrawerNavigationComponent relay classic query
  • Combine to single QueryRenderer
  • Remove relay/unused-fields
    • DrawerRail fragment
    • DrawerNavigationComponent fragment, might need to be updated

Description

Updated DrawerNavigation to relay modern and added a fragment to DrawerRail. The DrawerNavigationComponent was able to be deleted and the rendered components moved to the DrawerNavigation component. Relay files that were no longer used were also deleted

References: CV2-5978

Type of change

  • Performance improvement and/or refactoring (non-breaking change that keeps existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Security mitigation or enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Automated test (add or update automated tests)

How has this been tested?

Manually, and the DrawerNavigationComponent unit test was deleted

Things to pay attention to during code review

There were some instances of team.private being used, which I didn't touch at this point. But I could remove those as well if needed.

Checklist

  • I have performed a self-review of my own code
  • I've made sure my branch is runnable and given good testing steps in the PR description
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I implemented any new components, they are self-contained, their propTypes are declared and they use React Hooks and, if data-fetching is required, they use Relay Modern with fragment containers
  • If my components involve user interaction - specifically button, text fields, or other inputs - I have added a BEM-like class name to the element that is interacted with
  • To the best of my knowledge, any new styles are applied according to the design system
  • If I added a new external dependency, I included a rationale for doing so and an estimate of the change in bundle size (e.g., checked in https://bundlephobia.com/)
  • If I touched a file that included an eslint-disable-file header, I updated the code such that the disabler can be removed

@sarahkeh sarahkeh marked this pull request as ready for review January 16, 2025 01:38
Copy link
Contributor

@amoedoamorim amoedoamorim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @sarahkeh ! Thanks for cleaning it up!

@sarahkeh sarahkeh merged commit 8b0039a into develop Jan 21, 2025
11 checks passed
@sarahkeh sarahkeh deleted the cv2-5978-relay-modern-migration-DrawerNavigation branch January 21, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants