fix: refactor processElement to not exceed arguments limit

mcarvin8 · Apr 8, 2024 · db2bd59 · db2bd59
1 parent e2d6124
commit db2bd59
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 20 deletions.
diff --git a/src/helpers/types.ts b/src/helpers/types.ts
@@ -25,3 +25,16 @@ export const JSON_PARSER_OPTION = {
 export interface XmlElement {
   [key: string]: string | XmlElement | string[] | XmlElement[];
 }
+
+export interface ProcessElementParams {
+  element: XmlElement;
+  metadataPath: string;
+  uniqueIdElements: string | undefined;
+  rootElementName: string;
+  rootElementHeader: string;
+  key: string;
+  indent: string;
+  leafContent: string;
+  leafCount: number;
+  hasNestedElements: boolean;
+}
diff --git a/src/service/buildDisassembledFiles.ts b/src/service/buildDisassembledFiles.ts
@@ -47,7 +47,7 @@ export async function buildDisassembledFiles(
     if (Array.isArray(rootElement[key])) {
       for (const element of rootElement[key] as XmlElement[]) {
         const [updatedLeafContent, updatedLeafCount, updatedHasNestedElements] =
-          await processElement(
+          await processElement({
             element,
             metadataPath,
             uniqueIdElements,
@@ -58,15 +58,15 @@ export async function buildDisassembledFiles(
             leafContent,
             leafCount,
             hasNestedElements,
-          );
+          });
         leafContent = updatedLeafContent;
         leafCount = updatedLeafCount;
         hasNestedElements = updatedHasNestedElements;
       }
     } else {
       const [updatedLeafContent, updatedLeafCount, updatedHasNestedElements] =
-        await processElement(
-          rootElement[key] as XmlElement,
+        await processElement({
+          element: rootElement[key] as XmlElement,
           metadataPath,
           uniqueIdElements,
           rootElementName,
@@ -76,7 +76,7 @@ export async function buildDisassembledFiles(
           leafContent,
           leafCount,
           hasNestedElements,
-        );
+        });
       leafContent = updatedLeafContent;
       leafCount = updatedLeafCount;
       hasNestedElements = updatedHasNestedElements;

diff --git a/src/service/processElement.ts b/src/service/processElement.ts
@@ -1,20 +1,24 @@
 "use strict";
 
-import { XmlElement } from "@src/helpers/types";
 import { buildNestedFile } from "@src/service/buildNestedFiles";
+import { ProcessElementParams } from "@src/helpers/types";
 
 export async function processElement(
-  element: XmlElement,
-  metadataPath: string,
-  uniqueIdElements: string | undefined,
-  rootElementName: string,
-  rootElementHeader: string,
-  key: string,
-  indent: string,
-  leafContent: string,
-  leafCount: number,
-  hasNestedElements: boolean,
+  params: ProcessElementParams,
 ): Promise<[string, number, boolean]> {
+  const {
+    element,
+    metadataPath,
+    uniqueIdElements,
+    rootElementName,
+    rootElementHeader,
+    key,
+    indent,
+    leafContent,
+    leafCount,
+    hasNestedElements,
+  } = params;
+
   if (typeof element === "object") {
     await buildNestedFile(
       element,
@@ -25,11 +29,10 @@ export async function processElement(
       key,
       indent,
     );
-    hasNestedElements = true;
+    return [leafContent, leafCount, true];
   } else {
     const fieldValue = element;
-    leafContent += `${indent}<${key}>${String(fieldValue)}</${key}>\n`;
-    leafCount++;
+    const updatedLeafContent = `${leafContent}${indent}<${key}>${String(fieldValue)}</${key}>\n`;
+    return [updatedLeafContent, leafCount + 1, hasNestedElements];
   }
-  return [leafContent, leafCount, hasNestedElements];
 }