refactor: normalize path to unix when found

mcarvin8 · Jan 9, 2025 · 34bb533 · 34bb533
1 parent d96bd88
commit 34bb533
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/src/handlers/cloverCoverageHandler.ts b/src/handlers/cloverCoverageHandler.ts
@@ -1,7 +1,6 @@
 'use strict';
 
 import { CloverCoverageObject, CloverFile, CoverageHandler } from '../helpers/types.js';
-import { normalizePathToUnix } from '../helpers/normalizePathToUnix.js';
 
 export class CloverCoverageHandler implements CoverageHandler {
   private readonly coverageObj: CloverCoverageObject;
@@ -45,7 +44,7 @@ export class CloverCoverageHandler implements CoverageHandler {
   ): void {
     const fileObj: CloverFile = {
       '@name': fileName,
-      '@path': normalizePathToUnix(filePath),
+      '@path': filePath,
       metrics: {
         '@statements': uncoveredLines.length + coveredLines.length,
         '@coveredstatements': coveredLines.length,

diff --git a/src/handlers/coberturaCoverageHandler.ts b/src/handlers/coberturaCoverageHandler.ts
@@ -1,7 +1,6 @@
 'use strict';
 
 import { CoberturaCoverageObject, CoberturaPackage, CoberturaClass, CoverageHandler } from '../helpers/types.js';
-import { normalizePathToUnix } from '../helpers/normalizePathToUnix.js';
 
 export class CoberturaCoverageHandler implements CoverageHandler {
   private readonly coverageObj: CoberturaCoverageObject;
@@ -41,7 +40,7 @@ export class CoberturaCoverageHandler implements CoverageHandler {
   ): void {
     const classObj: CoberturaClass = {
       '@name': fileName,
-      '@filename': normalizePathToUnix(filePath),
+      '@filename': filePath,
       '@line-rate': '0',
       '@branch-rate': '1',
       methods: {},

diff --git a/src/handlers/lcovCoverageHandler.ts b/src/handlers/lcovCoverageHandler.ts
@@ -1,7 +1,6 @@
 'use strict';
 
 import { CoverageHandler, LcovCoverageObject, LcovFile } from '../helpers/types.js';
-import { normalizePathToUnix } from '../helpers/normalizePathToUnix.js';
 
 export class LcovCoverageHandler implements CoverageHandler {
   private readonly coverageObj: LcovCoverageObject;
@@ -18,7 +17,7 @@ export class LcovCoverageHandler implements CoverageHandler {
     coveredLines: number[],
   ): void {
     const lcovFile: LcovFile = {
-      sourceFile: normalizePathToUnix(filePath),
+      sourceFile: filePath,
       lines: [],
       totalLines: uncoveredLines.length + coveredLines.length,
       coveredLines: coveredLines.length,

diff --git a/src/handlers/sonarCoverageHandler.ts b/src/handlers/sonarCoverageHandler.ts
@@ -1,7 +1,6 @@
 'use strict';
 
 import { SonarCoverageObject, SonarClass, CoverageHandler } from '../helpers/types.js';
-import { normalizePathToUnix } from '../helpers/normalizePathToUnix.js';
 
 export class SonarCoverageHandler implements CoverageHandler {
   private readonly coverageObj: SonarCoverageObject;
@@ -16,7 +15,7 @@ export class SonarCoverageHandler implements CoverageHandler {
     lines: Record<string, number>,
   ): void {
     const fileObj: SonarClass = {
-      '@path': normalizePathToUnix(filePath),
+      '@path': filePath,
       lineToCover: [],
     };
     for (const lineNumberString in lines) {

diff --git a/src/helpers/findFilePath.ts b/src/helpers/findFilePath.ts
@@ -3,6 +3,7 @@
 
 import { readdir, stat } from 'node:fs/promises';
 import { join, relative } from 'node:path';
+import { normalizePathToUnix } from './normalizePathToUnix.js';
 
 export async function findFilePath(
   fileName: string,
@@ -13,6 +14,7 @@ export async function findFilePath(
   for (const directory of packageDirectories) {
     relativeFilePath = await findFilePathinDirectory(fileName, directory, repoRoot);
     if (relativeFilePath !== undefined) {
+      relativeFilePath = normalizePathToUnix(relativeFilePath)
       break;
     }
   }