Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add import aliases to fake package when necessary #111

Merged

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Dec 29, 2018

Branched from #109

Format the import line in Import.String() so that the template only needs to print the import and unnecessary aliases (where the alias is identical to the package path base) will not be added.

To remove unnecessary aliases in templates. Also makes the template a
little cleaner by removing the need to format the import line in
the template.
@dnephin dnephin changed the title Imports without unnecessary aliases Only add Import aliases to template when necessary Dec 30, 2018
@dnephin dnephin changed the title Only add Import aliases to template when necessary Only add import aliases to template when necessary Dec 30, 2018
@dnephin dnephin changed the title Only add import aliases to template when necessary Only add import aliases to fake package when necessary Dec 30, 2018
@joefitzgerald joefitzgerald merged commit 89938a0 into maxbrunsfeld:master Jan 8, 2019
@dnephin dnephin deleted the imports-without-unnecessary-aliases branch January 8, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants