Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: CI Improvements #2918

Merged
merged 17 commits into from
Dec 13, 2023
Merged

E2E: CI Improvements #2918

merged 17 commits into from
Dec 13, 2023

Conversation

yasserfaraazkhan
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan commented Nov 26, 2023 •
edited
Loading

Due to playwright old version 1.28.1, the launch of elecron instance was not returning the browser context to the test. Resulting in a timeout errors.

  • Updated playwright version to v1.40.0
  • Added a way to remove E2E label after all tests have finished.
  • Create separate instance from /cloud' plugin desktop-e2e-instance.test.mattermost.cloud`. This currently has 9.3.0 version.
  • Fixed RobotJS failing on MacOS e2e instance.
NONE

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Nov 26, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Nov 26, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 5, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 5, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 5, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 5, 2023
@yasserfaraazkhan yasserfaraazkhan marked this pull request as ready for review December 5, 2023 13:57
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 5, 2023
@yasserfaraazkhan yasserfaraazkhan added Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests and removed Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests labels Dec 5, 2023
@yasserfaraazkhan yasserfaraazkhan removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 6, 2023
@yasserfaraazkhan yasserfaraazkhan changed the title E2E: improvements E2E: CI Improvements Dec 6, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 6, 2023
@yasserfaraazkhan yasserfaraazkhan added Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests and removed Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests labels Dec 6, 2023
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 7, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 7, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 7, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 7, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 7, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 8, 2023
@yasserfaraazkhan yasserfaraazkhan added Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests and removed Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests labels Dec 8, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 8, 2023
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 8, 2023
@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 8, 2023
M-ZubairAhmed
M-ZubairAhmed approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :shipit: Thank you

saturninoabril
saturninoabril approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yasser!

@yasserfaraazkhan yasserfaraazkhan merged commit 675ec6d into master Dec 13, 2023
16 checks passed
@yasserfaraazkhan yasserfaraazkhan deleted the improve_tests branch December 13, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbinnie devinbinnie devinbinnie approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yasserfaraazkhan @saturninoabril @M-ZubairAhmed @devinbinnie @mm-cloud-bot @mattermost-build