[MM-55054] Consider a matching origin for a media request as a trusted URL when checking permissions #2893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the new permission changes, we were stopping servers with subpaths from being able to grant the
media
permission, due to being too strict about which URLs we were considering trusted.The
media
permission generally populates thesecurityOrigin
field when doing a permission check, so when checking for that permission if the URL can be trusted, we just need to match the two origins.This PR makes that exception in the permissions handler.
Ticket Link
https://mattermost.atlassian.net/browse/MM-55054
Closes #2881