[MM-54979] Stop auto opening Boards/Playbooks tabs, close existing open tabs once for users that might have them open #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en tabs once for users that might have them open
devinbinnie
added
2: Dev Review
BenCookie95
approved these changes
Oct 23, 2023
hmhealey
approved these changes
Oct 23, 2023
|
Building app in separate branch. |
|
@abhijit-singh You can test this using this build: https://github.com/mattermost/desktop/suites/17581574331/artifacts/1004610688 |
abhijit-singh
approved these changes
Oct 25, 2023
devinbinnie
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To improve overall memory usage, we are electing to stop opening the Boards and Playbooks tabs automatically when a new server is added. These tabs are often left running unnecessarily and take up memory.
Additionally, I've added a migration to close the tabs for everyone who currently has them open. This would be a good memory improvement for those who aren't using the tabs, but will be a bit jarring for those who do. They can re-open them afterwards and shouldn't see any further effects. cc @abhijit-singh on what you think of this approach/if you have any better ideas.
Ticket Link
https://mattermost.atlassian.net/browse/MM-54979