Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

We don't provide enough info in invites to unnamed rooms to name them correctly in clients. #12835

Open
ara4n opened this issue May 22, 2022 · 1 comment
Labels
A-Invite Inviting users to rooms and accepting invites T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@ara4n
Copy link
Member

ara4n commented May 22, 2022

If you:

  • create a private room (e.g. a DM)
  • invite someone to it
  • their client will show an invite that says "Matthew invited you to chat", rather than showing the correct synthetic name of the room (e.g. "Matthew and Amandine and 5 others").

We should provide sufficient state in the invite event for the target client to correctly synthesise the right name.

If this needs a spec change, then i'd expect one to be filed alongside fixing this in synapse.

This is a major UX shortcoming - refiled from element-hq/element-meta#379

@babolivier babolivier added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label May 23, 2022
@clokep
Copy link
Member

clokep commented May 23, 2022

By default we send (as matching the spec):

_DEFAULT_PREJOIN_STATE_TYPES = [
EventTypes.JoinRules,
EventTypes.CanonicalAlias,
EventTypes.RoomAvatar,
EventTypes.RoomEncryption,
EventTypes.Name,
# Per MSC1772.
EventTypes.Create,
# Per MSC3173.
EventTypes.Topic,
]

We would probably need to ensure enough information is sent for a client to run a similar algorithm to our calculate_room_name, that means we're likely missing:

  • m.room.canonical_alias
  • Information that this is a DM (or that there's only a single other user)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Invite Inviting users to rooms and accepting invites T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

4 participants