Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invites to unnamed DMs don't give any info about the conversation you're being invited to #379

Open
ara4n opened this issue Jan 14, 2021 · 9 comments
Labels
A-Invite O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Enhancement X-Needs-Product More input needed from the Product team Z-Chronic

Comments

@ara4n
Copy link
Member

ara4n commented Jan 14, 2021

I invited Amandine to an existing DM, and she got this:

image

We should be naming the invite using a synthetic room name if it has one, rather than just the name of the inviter.

@ara4n ara4n added the T-Defect label Jan 14, 2021
@t3chguy
Copy link
Member

t3chguy commented Jan 14, 2021

Presumably the issue here is A wouldn't know that its a DM as Synapse wouldn't share your room account data m.direct flag for that, so to the invitee it looks just like any other unnamed room with 2 existing members

@turt2live
Copy link
Member

it should have sent the m.direct flag down the invite's membership event though

@ara4n
Copy link
Member Author

ara4n commented Jan 14, 2021

alternatively, it could synthesise a better room name when sending the invite.

@turt2live
Copy link
Member

Looks like we definitely aren't considering the alias for the room either:

image

@jryans jryans added S-Tolerable Low/no impact on users A-Invite labels Feb 12, 2021
@t3chguy
Copy link
Member

t3chguy commented May 17, 2022

If you are still experiencing this please open an issue in https://github.com/matrix-org/synapse/

alternatively, it could synthesise a better room name when sending the invite.

Element cannot do this given how opaque the /invite API is

@ara4n
Copy link
Member Author

ara4n commented May 22, 2022

This is literally one of the top 10 UX problems in Element today (by my metrics, at least).

  • Have filed an explicit bug against backend to add the needed API
  • Have reopened this, because once the API is available, EW will need to be changed to use it (likewise EI & EA)

@ara4n ara4n reopened this May 22, 2022
@novocaine novocaine added T-Enhancement X-Needs-Product More input needed from the Product team and removed P1 T-Defect labels May 23, 2022
@t3chguy t3chguy transferred this issue from element-hq/element-web Jun 6, 2022
@daniellekirkwood
Copy link
Contributor

@giomfo @gaelledel
This feels like a relevant issue for y'all. Will your work in the DMs space resolve this?

@giomfo
Copy link
Member

giomfo commented Jun 8, 2022

@daniellekirkwood I would say no for the moment. This issue requires first some changes in the data available for an invited room.
matrix-org/synapse#12835 should be considered first with eventually designer point of view

@kittykat kittykat added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Invite O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Enhancement X-Needs-Product More input needed from the Product team Z-Chronic
Projects
None yet
Development

No branches or pull requests

9 participants