Bump node version to 18 #496
Conversation
H-Shay
force-pushed
the
shay/fix_node
branch
2 times, most recently
from
d180dc8 to
43e04e5
Compare
|
|
||
| interface Context extends Mocha.Context { | ||
| moderator?: MatrixClient, | ||
| appservice?: MjolnirAppService | ||
| } | ||
|
|
||
| dns.setDefaultResultOrder('ipv4first'); | ||
|
|
There was a problem hiding this comment.
needed because apparently node 17+ defaults to IVP6 but GH actions doesn't support IPV6 - see discussion at https://github.com/matrix-org/conference-bot/pull/186/files/85059d8f92ddcfb80657a58f60ef891ce704dfec..723a939d4726aa9de86fae0693137d78674154cb
this caused me a lot of pain until I figured it out...
There was a problem hiding this comment.
what a nightmare, and weird that it tries to do that...
We should put a similar comment from the conference bot's code here too, for when we inevitably try to remove it by accident. Likewise on the other files.
|
Just wanted to note that #493 requires a release to be fixed fully. Just bumping node version to 18 doesnt actually fully address the issue due to the share of users who are not running mainline. |
|
Our process is to close issues as fixed prior to release, then release as needed. The "Fixes" keyword autocloses the issue upon merge, which is the desired effect here. |
|
|
||
| interface Context extends Mocha.Context { | ||
| moderator?: MatrixClient, | ||
| appservice?: MjolnirAppService | ||
| } | ||
|
|
||
| dns.setDefaultResultOrder('ipv4first'); | ||
|
|
There was a problem hiding this comment.
what a nightmare, and weird that it tries to do that...
We should put a similar comment from the conference bot's code here too, for when we inevitably try to remove it by accident. Likewise on the other files.
|
Added requested comments and merged #496 into main, thanks for the review! |
Node 16 is EOL. Fixes #493.