-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4238: Pinned events read marker #4238
Open
ajbura
wants to merge
4
commits into
matrix-org:main
Choose a base branch
from
ajbura:pin-read-marker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# MSC4238: Pinned events read marker | ||
|
||
Currently, messages are pinned using the `m.room.pinned_events` state event (see | ||
[specification](https://spec.matrix.org/v1.12/client-server-api/#mroompinned_events)). However, when new messages are | ||
pinned by the super user, other users can not detect newly pinned messages. | ||
|
||
It primarily happen because `m.room.pinned_events` does not have any information that can help users detect the change. | ||
Resulting in users having no visual clues about newly pinned message. To cope with it they either have to mentally | ||
remember the total number of pinned message or discovery of `m.room.pinned_events` state event in clients timeline | ||
reminds them to check for possibly new pinned messages. | ||
|
||
## Proposal | ||
|
||
Client should set read marker in user's room account data (see | ||
[specification](https://spec.matrix.org/v1.12/client-server-api/#put_matrixclientv3useruseridroomsroomidaccount_datatype)) | ||
after detecting that the user has read the pinned messages. The `type` of this account data is `m.read.pinned_events` | ||
and body content look like: | ||
```json | ||
{ | ||
"event_id": "$xyz" | ||
} | ||
``` | ||
where `$xyz` is the `event_id` of `m.room.pinned_events` state event, signifying all pinned events as read. | ||
|
||
Subsequently, when client receives the new `m.room.pinned_events` state event, it can fetch the previously marked state | ||
event using the | ||
[/rooms/{roomId}/event/{event}](https://spec.matrix.org/v1.12/client-server-api/#get_matrixclientv3roomsroomideventeventid) | ||
endpoint. It can then identify the newly pinned messages by filtering the received state event for event IDs that are | ||
not present in the previously marked state event. | ||
|
||
|
||
## Potential issues | ||
Unknown | ||
|
||
## Alternative | ||
Unknown | ||
|
||
## Security considerations | ||
Unknown | ||
|
||
## Unstable prefix | ||
`org.matrix.msc4238.read.pinned_events` for `m.read.pinned_events` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation requirements: