-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4235: via
query param for hierarchy endpoint
#4235
base: main
Are you sure you want to change the base?
Conversation
server_name
query param for hierarchy endpointserver_name
query param for hierarchy endpoint
server_name
query param for hierarchy endpointvia
query param for hierarchy endpoint
|
||
To request the hierarchy of a space, clients need to call the | ||
[/hierarchy](https://spec.matrix.org/v1.9/client-server-api/#get_matrixclientv1roomsroomidhierarchy) endpoint introduced | ||
in [MSC2946](https://github.com/matrix-org/matrix-spec-proposals/pull/2946). This endpoint does not require user to join |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should link to the spec if possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it already has link to the hierarchy spec or I am missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason to link to the MSC then, it's confusing.
the room before responding with hierarchy details. It instead check whether the room is potentially joinable (per | ||
[MSC3173](https://github.com/matrix-org/matrix-spec-proposals/pull/3173)) before responding. | ||
|
||
Because it does not require a space room to be joined before calling this endpoint, it's possible that the requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would this happen? From a room directory response? I'm unsure what user interactions would cause this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User interactions are implementation specific, this MSC is trying to fix the issue in the hierarchy spec. An example using the via param would be requesting the only part of sub-spaces hierarchy which is unknown the the client. I have listed some more example of how this could be helpful in the MSC itself.
Rendered