test: minimize usage of EventFactory::state_key
#4562
Merged
+59
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was used in places where we could make use of other helpers, in some cases. Also introduces the `room_avatar` helper to create the room avatar state event.
Hywan
approved these changes
Jan 21, 2025
| let mut content = RoomAvatarEventContent::new(); | ||
| content.url = Some(avatar_url_1.to_owned()); | ||
| let event = factory.event(content).state_key("").into_raw_sync(); | ||
| let event = factory.room_avatar().url(avatar_url_1).into_raw_sync(); |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4562 +/- ##
==========================================
- Coverage 85.41% 85.39% -0.02%
==========================================
Files 285 285
Lines 32218 32218
==========================================
- Hits 27518 27514 -4
- Misses 4700 4704 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was used in places where we could make use of other helpers, in some cases. Also introduces the
room_avatarhelper to create the room avatar state event.Part of #3716