Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update the pinned_event integration tests code #4559

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmartinesp
Copy link
Contributor

Changes:

  • Make sure the pinned_event integration tests use MatrixMockServer behind the scenes.

  • Fix a bug in the RoomEventEndpoint that caused the match_event_id option to not actually work because the event id has a $local-part:server-name format and the path_regex function of WireMock would parse the whole ^/_matrix/client/v3/rooms/.*/event/$local-part:server-name as just ^/_matrix/client/v3/rooms/.*/event/$ because it'll take the $ char as the 'end of regex' one.

  • Remove unused mock_event legacy mocking method.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

…t ids since the regex was incorrectly parsed by wiremock
This is done so the tests there use the new APIs based on `MatrixMockServer`.
@jmartinesp jmartinesp requested a review from a team as a code owner January 20, 2025 16:41
@jmartinesp jmartinesp requested review from bnjbvr and removed request for a team January 20, 2025 16:41
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (dbadfe1) to head (e913074).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4559      +/-   ##
==========================================
+ Coverage   85.40%   85.43%   +0.02%     
==========================================
  Files         285      285              
  Lines       32218    32218              
==========================================
+ Hits        27516    27524       +8     
+ Misses       4702     4694       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant