Check matrix-sdk-ui compilation on wasm in CI #4545
Merged
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra 'wasm-flags' does not seem to add clarity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4545 +/- ##
==========================================
- Coverage 85.40% 85.40% -0.01%
==========================================
Files 285 285
Lines 32213 32213
==========================================
- Hits 27511 27510 -1
- Misses 4702 4703 +1 ☔ View full report in Codecov by Sentry. |
The others should likely be copied at some point as well, but including the readme as crate documentation is not currently useful since the readme for the ui crate is empty, and warning about missing docs or debug implementations would make CI fail without substantial extra work.
jplatte
force-pushed
the
jplatte/ui-js
branch
from
fbfe38b to
88a7137
Compare
poljar
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonas Platte [email protected]