Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(live_location_share): exclude live location events of own user #4535

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

torrybr
Copy link
Contributor

@torrybr torrybr commented Jan 15, 2025

This change ensures that the user's own live location events are excluded from the location sharing stream. Since the user's location is already represented on the map by the blue dot, processing their own events is redundant and unnecessary.

@torrybr torrybr requested a review from a team as a code owner January 15, 2025 14:14
@torrybr torrybr requested review from poljar and removed request for a team January 15, 2025 14:14
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (fe3cc09) to head (1d1003c).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4535   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         285      285           
  Lines       32112    32112           
=======================================
  Hits        27433    27433           
  Misses       4679     4679           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, though the test could be improved with our new mocking API.

crates/matrix-sdk/src/room/mod.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/tests/integration/room/beacon/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, thanks.

@poljar poljar enabled auto-merge (rebase) January 17, 2025 14:30
@poljar poljar disabled auto-merge January 17, 2025 14:39
@poljar poljar enabled auto-merge (squash) January 17, 2025 14:40
@poljar poljar merged commit 47fc073 into matrix-org:main Jan 17, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants